Eject on CDFS iconbar menu

Someone appears to have cunningly designed the CDFS iconbar menu to fade the Eject option when the drive is empty.
This possibly made sense for caddy-based CD drives, but any tray-based CD drive needs to be ejected before the
CD is inserted. Fading the menu option means that one has to physically interact with the CD drive, which can
be a pain if the drive is behind a facia etc.

Unless I’m missing something obvious, there’s no real advantage to fading the Eject option ever, beyond it seeming
like a cool idea to someone at the time it was done. In use, it just means that you can’t software-eject via the
menu unless you’ve first loaded the drive manually.

Presumably you’re going to physically interact with the drive anyway, if you’re going to put a disc in?

Someone appears to have cunningly designed the CDFS iconbar menu to fade the Eject option when the drive is empty.

I don’t understand this. I have just tried with Iyonix, PandaRO and ARMX6. All three have empty CD drives, yet the menu item for Eject is NOT faded, and choosing it does indeed open the empty drive. Am I missing something? All machines are on fairly recent RISC OS 5.23.

Presumably you’re going to physically interact with the drive anyway, if you’re going to put a disc in?

Ah, but if the guy that designed the case assumed you had a software eject button and hid the mechanical bits behind the fascia you can’t get it to open up to put a disc in.

Of course all academic when Chris points out that his “just works” because it isn’t greyed out.

The availability of the option isn’t based on whether the drive is empty; it’s based on whether CD_IsDrawerLocked says that the drawer is locked. If the drawer is locked (or the call returns an error) then it will grey out the option.

I’m seeing some odd things with the ATAPI driver on my Iyonix – the option is permanently greyed out, despite the fact that the *Eject command works fine. Also trying to eject a locked drive results in a “CD-ROM drive empty” error rather than something more sensible (e.g. “drive locked” – although locking an empty drive, which is what I’d done, probably isn’t an expected behaviour).

Anyway, this is definitely something that needs some more investigation.

This should be fixed now. Looks like the CD drivers were simply using the wrong command for checking the drawer lock status (probably a symptom of the age of the original driver implementation).

https://www.riscosopen.org/viewer/revisions/logs?ident=1518300359-342545.html
https://www.riscosopen.org/viewer/revisions/logs?ident=1518301585-799003.html

Works nicely for my BB -xM (drive is an awkward skinny portable). What should the action be for adjust-click on the iconbar icon?

Edit: Oh, the behaviour has changed when there is a disc in the drive. I’m sure adjust-click used to eject the drive. Now it re-mounts the disc.