Bug in Fat32FS Filer Taskbar

I experience this layout bug that the space reserved for the name is too slim for the name to fit into.
See screenshot:

Screenshot of Name display bug

Who can fix it?

I think the guess isn’t good.

#ifdef SHOW_DRIVE_NAME_ON_ICON_BAR
  regs.r [1] = (int) text;
  _kernel_swi (Font_StringBBox, &regs, &regs);
  x = regs.r [3] - regs.r [1];		// Max X - Min X
  x = x / 360;				// Divide by 360 is a guess
  if (x < 68) x = 68;

In source → module → c → wimp.

There’s a lot of wrongness there. StringBBox says “This call cannot, due to rounding and anti-aliasing, be used to find size on screen”. ;)

And while the default conversion is 400 millipoints to an OS unit (there’s the call Font_ConverttoOS SWI), I think the guess of 360 is to try to work around StringBBox returning potentially duff values?

Wouldn’t it be better to replace all of that with Wimp_TextOp, 1?

Yes! Wimp_TextOp, 1 should be used here.

@Rick I tried to find it in GitLap RISC OS sources but failed.
Can you point me exactly to the code?
Like https://gitlab.riscosopen.org/RiscOS/Modules

It is time to get the latest version of Fat32FS 1.63 09Jan24. Wimp_TextOp,1 is now used.

See changelog in the ReadMe.

The code is in Fat32FS/zip.Source.Module.c.wimp at line 133.

@David Great ! Thanks!

One good news and one bad news:
Text is OK now but when I open the task bar menu and then move onto the menu content I get: Internal error: abort on data transfer &FC348E2C

but when I open the task bar menu and then move onto the menu content I get: Internal error: abort on data transfer &FC348E2C

Seems all OK here on an RPi4 and Titanium with recent OS5.29s.

Does *where tell us anything useful?

I found out more now:
When I don’t initialize the USB stick by clicking on the drive icon and first open the task bar menu it will not crash later.
When I open the drive after that and open the task bar menu all is OK.

So something goes wrong with initialzing the menu when the drive is opened already. In version 1.56 it didn’t happen.
I have RISC OS 5.29

Does *where tell us anything useful?

What does it mean? WHat can I do get more debugging infos?

here list of modules:
MOS Utilities 5.29 (20 Nov 2023)
PCI Manager 0.19 (29 Aug 2020)
FileSwitch 2.92 (25 Mar 2023)
ResourceFS 0.26 (18 Aug 2016)
Territory Mgr 0.58 (25 Jan 2021)
UK Messages 1.12 (26 Sep 2020)
MessageTrans 0.49 (26 May 2012)
C Library 6.21 (09 Aug 2023)
Screen Modes 0.74 (02 Mar 2020)
rk3399video 0.22 (21 Aug 2023)
Desktop 2.77 (26 Oct 2018)
Task Manager 1.54 (10 Jul 2021)
ZeroPain 0.10 (30 May 2020)
Window Manager 5.86 (24 Jun 2023)
Debugger 2.08 (19 Jun 2021)
UK Territory 0.64 (01 Feb 2021)
FPEmulator 4.39 (28 Jan 2022) (1.13CELM)
BBC BASIC V 1.85 (03 Oct 2022)
BBC BASIC VI 1.85 (03 Oct 2022) FPA
BBC BASIC VI 1.85 (03 Oct 2022) VFP
Buffer Manager 0.39 (14 Mar 2011)
DeviceFS 0.73 (23 Apr 2016)
Colour Selector 1.97 (30 Aug 2023)
International 1.70 (06 Feb 2021)
Int’l Keyboard 1.00 (06 Feb 2021)
RTSupport 0.18 (18 Oct 2023)
USBDriver 1.31 (04 Jul 2020)
XHCIDriver 0.30 (12 Sep 2020)
EHCIDriver 0.42 (04 Jul 2020)
OHCIDriver 0.55 (04 Jul 2020)
DisplayManager 0.44 (29 May 2016)
DMAManager 0.23 (07 Nov 2015)
Drag A Sprite 0.21 (30 Aug 2017)
Drag An Object 0.10 (16 Nov 2022)
Drawing Module 1.22 (08 May 2016)
FileCore 3.78 (15 Apr 2023)
Filer 2.49 (15 May 2023)
FilerSWIs 0.05 (16 Mar 2001)
Font Manager 3.80 (20 Jul 2020)
VFPSupport 0.18 (24 Nov 2021)
Free 0.42 (29 May 2016)
Hourglass 2.19 (10 Nov 2013)
IIC 0.18 (02 Feb 2017) 4.5.2.13
Inverse Table 0.18 (06 Oct 2013)
Obey 0.41 (06 Feb 2021)
Pinboard 2.02 (29 Jun 2023)
PipeFS 0.25 (23 Jan 2023)
RAMFSFiler 0.41 (29 Feb 2020)
ROM Fonts 0.78 (11 Feb 2023)
SpriteExtension 1.86 (03 Oct 2022)
ShellCLI 0.39 (09 Aug 2023)
BlendTable 0.02 (09 Mar 2014)
SpriteUtils 1.13 (19 Jan 2010)
Squash 0.31 (11 Feb 2023)
SuperSample 0.16 (14 Jan 2012)
System Devices 1.34 (22 Oct 2022)
TaskWindow 0.85 (17 Oct 2022)
Window Utils 2.53 (05 Apr 2001)
Filter Manager 0.30 (21 Aug 2023)
Colour Picker 0.59 (03 Nov 2021)
DrawFile 1.62 (09 Jan 2023)
Filer_Action 0.64 (15 May 2023)
DOSFS 1.15 (01 Mar 2023)
SCSIDriver 2.15 (13 Jul 2018)
SCSISoftUSB 0.28 (18 May 2020)
SCSIFS 1.36 (19 Aug 2020)
SCSIFiler 1.33 (26 Feb 2020)
PartMan 0.16 (14 Jan 2023)
ScreenBlanker 2.34 (08 May 2016)
ScrSaver 0.14 (01 Aug 2015) 1.9.2.4
Serial 0.25 (24 Apr 2017) 4.8.2.16
Serial Support 0.26 (04 Jun 2012)
FSLock 1.26 (07 May 2022)
SoundDMA 1.88 (04 Aug 2018) HAL version
Sound Control 1.06 (10 Sep 2016)
SoundChannels 1.43 (20 Jun 2023)
SoundScheduler 1.34 (01 Jun 2022)
WaveSynth 1.25 (08 May 2016)
StringLib 1.20 (03 Mar 2021)
Percussion 1.19 (03 Mar 2021)
Shared Sound 1.20 (18 Jun 2016)
SDIODriver 0.18 (21 Jan 2023)
SDFS 0.11 (18 Jul 2022)
SDFSFiler 1.15 (26 Feb 2020)
SDCMOS 0.21 (12 Jun 2021)
RTC 0.02 (04 Apr 2019)
Boot Commands 1.53 (19 Oct 2022)
AUN Messages 0.30 (23 Oct 2016)
BootNet 0.97 (17 Jun 2015)
MimeMap 0.19 (15 Apr 2016)
!Edit 1.75 (05 Sep 2020)
!Draw 1.46 (19 Aug 2023)
!Paint 2.54 (30 Aug 2023)
!Alarm 2.96 (14 Aug 2021)
!Chars 2.06 (17 Sep 2022)
!Help 3.27 (04 Nov 2020)
Toolbox 1.60 (15 Feb 2023)
Window Object 1.80 (25 Jan 2023)
ToolAction 0.38 (20 Mar 2016)
Menu 0.42 (28 Aug 2023)
Iconbar 1.23 (18 Jun 2016)
ColourDbox 0.23 (25 Jan 2023)
ColourMenu 0.23 (09 Sep 2018)
DCS Object 1.14 (25 Jan 2023)
FileInfo 0.21 (25 Jan 2023)
FontDbox 0.19 (25 Jan 2023)
FontMenu 0.26 (09 Sep 2018)
PrintDbox 0.18 (25 Jan 2023)
ProgInfo 0.19 (25 Jan 2023)
SaveAs 0.21 (25 Jan 2023)
Scale 0.18 (25 Jan 2023)
TextGadgets 0.45 (25 Jan 2023)
WindowScroll 0.02 (29 Apr 2020)
CDFSDriver 2.42 (22 Jun 2020)
CDFSSoftSCSI 0.06 (10 Feb 2018)
CDFS 2.63 (08 May 2016)
CDFSFiler 2.52 (29 Feb 2020)
UnSqueezeAIF 0.10 (18 Nov 2013)
DDEUtils 1.75 (12 Jul 2015)
RISC OS NFS 3.29 (28 Dec 2022)
CryptRandomIPv6 0.20 (18 Dec 2023) Theo Markettos theo@markettos.org.uk
MbufManager 7.04 (18 Dec 2023)
Internet 7.04 (18 Dec 2023)
EtherTH 7.04 (18 Dec 2023)
EtherUSB 7.04 (18 Dec 2023) James Peacock DualStack
DCIShim 7.04 (18 Dec 2023)
Resolver 7.04 (18 Dec 2023)
DHCP 7.04 (18 Dec 2023)
SLAAC 7.04 (18 Dec 2023)
LanManFS 2.70 (02 Oct 2023)
RamFS 2.33 (23 Nov 2020)
JetDirectFS 2.02 (18 Aug 2011) R-Comp 2011
lprDeviceDriver 2.02 (23 May 2005) Peter Bell/FSC Distributed by R-Comp Interactive
Freeway 0.42 (13 Feb 2023)
ShareFS 3.62 (18 Mar 2023) Access+
Fat32fs 1.63 (09 Jan 2024)
KeyMapper 0.01 (25 Jun 2004) James Peacock
XML Support 0.43 (13 Jun 2020) Paul Reuvers/XAT 2004-2020
SharedUnixLibrary 1.16 (3 Apr 2020) © UnixLib Developers, 2001-2020
StrongTask 1.03 (28 Dec 2002) StrongED developers
DitherExtend 0.64 (24 Feb 2016) 1992-2016 CC & MW Software
Artworks Render 2.16 (12 Nov 2011) 2011 CC and MW Software
GSpriteExtend 0.75 (18 Feb 2016) 1993-2016 CC and MW Software
CC Draw Module 3.12 (17 Mar 2011) 2011 CC and MW Software
SpecialFX 1.05 (27 May 2004)
NetTime 0.44 (30 Nov 2019)
Printer sharer 3.40 (08 Apr 2016)
RemPrnSpt 1.15 (15 Nov 2015)
Printer driver 4.64 (18 Jul 2018) for PostScript printers (UCS)
MakePSFont 1.18 (02 Jun 2018)
SparkFS 1.50 (27 Jan 2023)
ImageFSFix 0.07 (16 Sep 2012)
Spark 1.51 (12 Jun 2023)
Tar 1.51 (05 Apr 2023)
Zip 1.51 (29 Apr 2023)
WimpSWIVe 0.08 (23 Mar 2003)
PhotoFiler 2.10 (12 Jun 2020) David Thomas, 1998-2020
TreeView 0.22 (08 Sep 2015) Rik Griffin 2003-15
Tinct 0.14 (25 Apr 2009) [fr]
FilerHRun 1.21 (20 Jan 2003) Musus Umbra

Here’s a link to the RISC OS Debugging guide.

What does it mean? WHat can I do get more debugging infos?

Another link that describe the “where” command and others.

Edit: the following description of the where command fits my understanding. Is there anyone comfortable enough with Textile able to update the wiki entry?

So something goes wrong with initialzing the menu when the drive is opened already.

I still cannot reproduce any error.

*where is provided by the ROM Debugger module and gives the owner of the space an abort occurs in. When called without any argument is gives a result for the last abort.

As well as
*WHERE

You could add

*SHOWREGS

Well there must be a difference in what is done when initialize the menu when is “empty”(no drive initialized) and when a drive is moouted.
The menu content is different. For example there is “Format” entry.

By the way why the drive is not automatically initialized when plugged in? Windows does that and I think i makes sense as anyhow the pluggin in is detected as otherwise the USB stick doesn’t show…

PS: About the debugging stuff I will look later today. Now no time for that.

By the way why the drive is not automatically initialized when plugged in?

AIUI, the drive is initialised, but only SCSIFS is aware of its existence to begin with.

Fat32Fs only gets interested in the drive when you left-click on the icon. You can choose to bypass Fat32Fs by right-clicking on the icon: this is most likely the reason why Fat32Fs isn’t interested in device insertions.

Where &FC348E2C : is at offset adress &00001C54 of module SCSIFiler

Register dump (stored at &2003D870) is:
R0 = 00000007 R1 = 203592F4 R2 = 00000006 R3 = FFFFFFFF
R4 = 20358E64 R5 = 0000006E R6 = 00000028 R7 = FFFFFFFF
R8 = 00000000 R9 = 00000000 R10 = 00000000 R11 = 00000500
R12 = 20358BF4 R13 = 203596E8 R14 = 7369446D R15 = FC348E34
Mode USR32 flags set: nZCvqjggggeAift PSR = 60000110

Most people will not discover this bug as it only happens when the task bar menu is opened. And then likely not to happen with all drives or device names.
To discover where can be the error I would look at the initialising of the menu when the drive is not mounted.
And compare it with the initializing when the drive is mounted.

Can you send me older version of FAt32FS like 1.59 and 1.60 (or all) ? The version that didn’t crash is 1.56.
then I can check from which version it happens.

@David
Can you do a quickfix that you call on startup of Fat32FS to fill the menu content (before mounting the device)?
That should prevent the crash later on.

A little bit offtopic…

Toni has send an FAT32FS bugfix in 02/2020 especially for the Ti SATA to Jeff. Looks like is not inside the latest version and older. So for me the latest version is not usable.
FAT32FS on SATA can not handle more then 256GB and partitions behind this. With SCSIFS it works without problems and with Tonis fix on SATA also. I use Tonis fix since 02/2020 without problems.

I take everything back and claim the opposite.
I misunderstood the email history of our GAG group. Toni wrote to Jeff about an error at the time (which resulted in data loss for me) but never submitted his code.
Jeff’s bugfix for my data loss was … FAT32 drives behind 256GB no longer mountable on Ti SATA.
Please excuse me!