Adjust-click on iconbar items
Jim Nagel (444) 25 posts |
Please could Adjust-clicking the Task Manager (“switcher”) on the iconbar open the “Configure” window? At present, Adjust does exactly the same as Select, which is a waste. |
David Feugey (2125) 2709 posts |
Or perhaps to open a more complete window, with open files, list of modules, etc. |
Rick Murray (539) 13840 posts |
Jim Nagel… Jim Nagel… Oh, Computer Shopper! Hi! Nice to see you here. [I know you’ve been here longer that I have, but you don’t post much. :-) ]
That is, actually, a really good idea. |
Rick Murray (539) 13840 posts |
Done. You will need to find somebody that can build you a ROM image, until this is integrated into the main ROM build. For those who want to try this… In …castle.RiscOS.Sources.Desktop.Switcher.s.Switcher, line 4332 says:
Change this to be:
The difference is the adjust copy goes to “goconfig” if it’s the icon bar that was clicked upon. The reason for the code duplication is that we use R14 to read what button was pressed (just above in mouse_click) and we then stamp all over R14 in our comparisons. So the quickest route to what we want is to just have two code paths that do mostly the same thing. No effect in code timing, requires 64 bytes extra. Not a hardship. I’ll email this to the code submissions address. I’m running this here, just rebuilt my ROM, and… yeah… It’s a nice tweak. |
Fred Graute (114) 645 posts |
Agreed, but how about this:
You might even be able to push |
Rick Murray (539) 13840 posts |
Not bad. I missed that iconbar_handle was a constant and not loaded into R14. Just building a version with your mods now. |
Rick Murray (539) 13840 posts |
Built, copied, works just fine. Don’t forget to mail your modifications to code@ ! :-) Nitpicky pointless optimisation stuff → I’d be inclined to swap the select and adjust blocks around so the most common case (clicking Select) can fall through without the additional branch and the pipeline trashing that would occur on older ARM cores (without speculative execution). |
Will Ling (519) 98 posts |
This was discussed a while back in thread Ways to make life easier for new RISC OS users ,for anyone not wanting to load a new rom yet, I knocked up a module then as a quick demo of an adjust click on switcher to open !Configure feature |