SCSISoftUSB finalise bug fix

In mixed.RiscOS.Sources.HWSupport.SCSI.SCSISoftUSB.c.module in module_Final, RemoveAllDevices is called before the deregistering of the upcall handler. RemoveAllDevices removes the module by doing a *usbreset. At this point service calls are disabled with the ‘No_New_Stuff’ flag to stop reattaching the devices. However the upcall handler isn’t disabled so the device streams are reopened before the module closes down. This causes a ‘Device Not Found’ error on shutdown.

You can see this happening by using !closefile.

If you plug in a usb drive !closefiles will show the open usb endpoints. Now rmkill scsisoftusb and refresh !closefile and you will see that the endpoints are still open.

This fixes it.

_kernel_oserror *module_UpCallVHandler(_kernel_swi_regs *r, void *pw)
{
  IGNORE(pw);
  if (((r->r[0] == 8) || (r->r[0] == 9) /* Buffer filling/emptying */ ) && global_TickerList && !global_RTSupportPollword) glue_BufferThresholdCheck(r->r[1],r->r[0]==8);

#if 1
  /*
   * FINALISE_FIX
   */
  if (!No_New_Stuff && r->r[0] == 11 /* stream closed */) glue_ReopenStream(r->r[3]);
#else
  if (r->r[0] == 11 /* stream closed */) glue_ReopenStream(r->r[3]);
#endif
  return NULL;
}