HALDevice_GPIO header extension

Hi

As part of making the iMx6 HAL interfaces more readily visible I am proposing to add the following to the HALDevice_GPIO header. Can anyone see any reason why not? The basic device API has ALDevice_Version = 0.

; Extra entries for API 0.1 with basic GPIO control in the HAL
; HALDevice_Version = 1           
HALDevice_GPIOReadBit            #       4
HALDevice_GPIOWriteBit           #       4
HALDevice_GPIOSetAsInput         #       4
HALDevice_GPIOSetAsOutput        #       4
HALDevice_GPIOSetAndEnableIRQ    #       4
HALDevice_GPIOIRQClear           #       4
HALDevice_GPIODisableIRQ         #       4
HALDevice_GPIOReadBitAddr        #       4
HALDevice_GPIODeviceNumber       #       4
HALDevice_GPIO_Size_0_1          *       :INDEX: @
;

This extends the HAL GPIO device to provide routines as above.
On entry a1 bits 7..0 contain GPIO#<<5 (1-7) + bitno (0-31)
For bit write and bit set as o/p a1 bit 8 is the desired state.
For IRQ set and enable a1 bits 1..8 are as follows:

; +  IRQ type flags <<8

;      (0<<8) = LEVELDETECT0

;      (1<<8) = LEVELDETECT1

;      (2<<8) = RISINGDETECT

;      (3<<8) = FALLINGDETECT

Replied by email….