ScrollList gadget bug

The scrolllist gadget shipped with RISC OS 5 appears to have an issue with the DeselectItem method. Clicking Adjust over a selected item doesn’t deselect it. Attempting to deselect all items results in them all getting selected.

A quick glance at the source suggests the fault is in the _SelectItems() function. When there’s to be only selected item all items are deselected first.

The code responsible for this, however, sets the variable ‘selected’ to ‘SELECT_SELECT’ overriding the value passed in. Because of this attempting to deselect one or all items fails.

As this seems to be such an easy problem it’s probably faster for someone with write permission to the CVS to fix this than it is for me to provide a patch. Besides, my copy of the sources is rather out of date (yes, I did check that the problem is still there in the latest revision).

sets the variable ‘selected’ to ‘SELECT_SELECT’ overriding the value passed in

Changed in TextGadgets 0.35.