Missing Menu Clicks

This is a bit odd, and has taken a while to pin down… :-)

Using yesterday’s dev build for a RiscPC on RPCemu; I’ve not tried any other system. It also applied to a build downloaded on Monday 30th.

Load SciCalc, or anything else which has a menu and uses icons in its window. With the window fully on screen, satisfy yourself that clicking Menu over it does indeed open the menu as expected. Try over some of the buttons, the window background, other icons in the window, etc.

Now drag the window partly off-screen to the left of the desktop. Try Menu again. Note how the menu only appears now when the pointer is over the window background. Menu clicks on icons are being swallowed up and not reported to the task.

Drag the window back on screen again, and normal service is resumed. The other sides of the desktop don’t seem to have this effect, unless off at the top does if the window could be moved beyond its title bar? Certainly left and bottom don’t.

This seems to be a newish thing: my laptop was running an oldish ROM image (maybe 12 months), and it was OK. When I updated it at the weekend, Launcher’s menu stopped working as described here. I’ve verified in Launcher that Wimp_Poll is not returning events when Menu is clicked over icons, when the window is off-screen; SciCalc just happens to be a quick way to show the problem.

Is this related to the wholesale changes to the Wimp’s mouse click event handling as part of the C&P stuff, or did things break in an older ROM build that I didn’t download?

Or am I just going mad? :-)

I tried with the 13 Nov 2019 IOMD build and the problem is not present. Doesn’t narrow it down all that much, but I don’t grab all that many IOMD builds and the Raspberry Pi is packed away. I’ll give it a more extensive test in the morning.

Tried this with 29-Dec-19 ROM on my BB -xM. Menu over the keys did nil. Menu over the background above the keys did nothing. Menu over the background below the keys produced the error, ‘Internal error, no stack for trap handler: Internal error: abort on instruction fetch at &36241108, pc=00000000: registers at 0000C3E4’. Cancel produced the error, ‘Message from SciCalc Not in a procedure (code1506)’. Clearing that exited SciCalc.

Second attempt produced the same result as Steve reports, without the error messages.

SciCalc was in Scientific mode.

Now drag the window partly off-screen to the left of the desktop. Try Menu again. Note how the menu only appears now when the pointer is over the window background. Menu clicks on icons are being swallowed up and not reported to the task.

This effect was introduced in WindowManager 5.65, ROM date 15 Dec 2019, WindowManager 5.64 is OK. Tested on a Titanium, and also with one of my own apps.

Thanks for that; I see it. It’s a variant on a bug that has been squashed and does relate to the new click handling bits. I will investigate further and sort it. It does affect other windows with icons if dragged partially off screen, but not if there are none (eg Filer). For some reason, Menu clicks are being mishandled at times still.

Update: I think I’ve fixed it now; I’ve submitted the update to ROOL this evening. Thanks for your patience!

I think I’ve fixed it now; I’ve submitted the update to ROOL this evening. Thanks for your patience!

Thanks for fixing it, and for all your work on the C&P implementation. Having tried to trace through the Mouse Click event code to see what might have been going on whilst trying to work out what the trigger for the bug was¹, I can’t say I envy your having to work on the Wimp source code. :-)

¹ It wasn’t helped by the fact that creating a very small BASIC program to use Launcher’s window template without all of the other complexity didn’t show up the problem. The inspiration about the window being off-screen only came several days into the hunt.