ChangeFSI colours scrambled on mode change

1. Select a fully-paletted 256-colour screen mode (e.g. X800 Y600 C256).
2. Ensure ChangeFSI is set to “Sprite output” with the sprite options set to “Use current mode” (i.e. the default).
3. Drag a JPEG image to the ChangeFSI icon on the icon bar. The image will be displayed as usual.
4. With the image still on-screen, use Display Manager to select a 16 million colour screen mode. The image will now have its colours scrambled.

If you start with a VIDC1-compatible screen mode (e.g. mode 28) it will not happen. Likewise it will not happen if you explicitly request a 16M colour sprite via ChangeFSI’s “sprite output” options.

This is a display bug: saving a sprite file will save the image in the originally-requested colour depth and the colours in the sprite will not be scrambled.

Witnessed at: RISC OS 5.24 (RPCEmu 0.9.4, ChangeFSI 1.61) and RISC OS 5.28 (Raspberry Pi, ChangeFSI 1.63)

Not affected: RISC OS 3.71 (RPCEmu 0.9.4, ChangeFSI 1.12)