FileSwitch

I discovered an issue, caused by giving a file to be copied the same name as one that already exists, the action of copying (*Copy) the file to the pre-existing filename generates an error message.

Internal error: abort on data transfer at &FC058B38
*where Address &FC058B40 is at offset &00006920 in module 'FileSwitch'

FileSwitch 2.91 (13 Mar 2023) – ROM (19-Mar-23), RPi 4.

Agreed. Just Tried it here …

RISC OS 5.29 (19 Mar 2023)  Titanium
C Library 6.19 (22 Feb 2023)
BBC BASIC V 1.85 (03 Oct 2022)
FileSwitch 2.91 (13 Mar 2023)
ZeroPain 0.10 (30 May 2020)

12:47:24.46 *copy Boot:!help ram:testcopy  ~c
12:47:24.46 *copy Boot:!help ram:testcopy  ~c
12:47:24.50 ** Error **
  Error  : &80000002
  Message: Internal error: abort on data transfer at &FC05830C
12:47:24.50 ** WimpError ** from unknown task
  Error  : &80000002
  Message: Internal error: abort on data transfer at &FC05830C

Address &FC058314 in Module   FileSwitch          @ &FC051A00 + &6914
Register dump (at &2007A3F0) is:
pc  = &FC058314  Flags=&60000013=nZCv if  Mode=SVC 32 bit
r0  = &00000001 :          1
r1  = &3020DE38 :  807460408 => &6D61523A : :Ram : 1835094586
r2  = &FC0576B0 : 4228216496 => &00374343 : CC7. : 3621699
r3  = &283B1270 :  674959984
r4  = &0000007E :        126
r5  = &00000003 :          3
r6  = &00000000 :          0
r7  = &00000009 :          9                         <<<<<<<<<<
r8  = &FA207AE4 : 4196432612
r9  = &3021149C :  807474332 => &30211288 : ˆ.!0 : 807473800
r10 = &00000000 :          0
r11 = &FA207CEC : 4196433132
r12 = &200001F4 :  536871412 => &00000008 : .... : 8
r13 = &FA207AA0 : 4196432544
r14 = &FC057708 : 4228216584 => &6AFFFFC8 : È..j : 1795162056
Code around address is:
FC0582DC : E3320000 : TEQ     R2,#0
FC0582E0 : 05C12000 : STREQB  R2,[R1,#0]
FC0582E4 : 1BFFEE5A : BLNE    &FC053C54
FC0582E8 : E8BD801E : LDMIA   R13!,{R1-R4,PC}
FC0582EC : 0000002E : ANDEQ   R0,R0,R14,LSR #32
FC0582F0 : E92D401E : STMDB   R13!,{R1-R4,R14}
FC0582F4 : EAFFFFE2 : B       &FC058284
FC0582F8 : E92D44FE : STMDB   R13!,{R1-R7,R10,R14}
FC0582FC : E3A0A000 : MOV     R10,#0
FC058300 : EA000000 : B       &FC058308
FC058304 : E92D44FE : STMDB   R13!,{R1-R7,R10,R14}
FC058308 : E92D0600 : STMDB   R13!,{R9,R10}
FC05830C > E8970442 : LDMIA   R7,{R1,R6,R10}           <<<<<<<<<<
FC058310 : E1A0700D : MOV     R7,R13
FC058314 : EB000770 : BL      &FC05A0DC
FC058318 : E1A0400D : MOV     R4,R13

It works fine with FileSwitch 2.89 …

RISC OS 5.29 (12 Jan 2023)  Titanium
C Library 6.16 (28 Dec 2022)
BBC BASIC V 1.85 (03 Oct 2022)
FileSwitch 2.89 (24 Dec 2022)
ZeroPain 0.10 (30 May 2020)

But FileSwitch 2.90 also fails…

RISC OS 5.29 (26 Jan 2023)  Titanium
C Library 6.16 (28 Dec 2022)
BBC BASIC V 1.85 (03 Oct 2022)
FileSwitch 2.90 (23 Jan 2023)
ZeroPain 0.10 (30 May 2020)
13:14:13.82 [WindowManager/] *copy Boot:!help ram:testcopy  ~c
13:14:13.83 [WindowManager/] *copy Boot:!help ram:testcopy  ~c
13:14:13.87 ** Error **
  Error  : &80000002
  Message: Internal error: abort on data transfer at &FC058296

Recently a lot of futzing to use fsfile_ReadInfoNoLen, I wonder if a register is being corrupted that the previous code didn’t? (the joy of assembler 😉).

Recently a lot of futzing to use fsfile_ReadInfoNoLen

Well RComp are looking at an issue I reported on these forums with JetDirectFS/UniPrint/Printers and potentially FileSwitch 2.91 may be involved in that.

This bug can be demonstrated from the Desktop bt turning off Filer multitasking. The mains switch might be needed afterwards though!

Mea culpa. Thanks for the report – a fix is now ready for merging.

https://gitlab.riscosopen.org/RiscOS/Sources/FileSys/FileSwitch/-/merge_requests/16

Thanks Jeffrey – Now fixed in ROM 5.29 (26 Mar 2023) with FileSwitch 2.92 (25 Mar 2023) – tested on Titanium.

Also, thank you, Jeffery – I can confirm that it has fixed not only the issue I reported but also resolved a Zap issue I was having, where opening multiple files caused the editor to crash. ROM 5.29 (26 Mar 2023), RPi 4.