RISC OS Open: Forum: ChangeFSI Bug

Jun 17, 2013 7:28pm

Malcolm Hussain-Gambles (1596) 811 posts

I’ve found a couple of times that when converting GIF files via ChangeFSI (v1.38) it crashes.
And as seems to be usual pain, leaves the file open…grrrr!
The GIF file seems fine and it loads fine using !PrivatEye

http://news.bbcimg.co.uk/media/images/68163000/gif/_68163045_44944066.gif

I think for my app I’ll disable ChangeFSI for GIF files for the moment, I’m only interested in the larger files which always seem to be jpgs anyway.

Jun 18, 2013 7:32am

Sprow (202) 1158 posts

I’ve found a couple of times that when converting GIF files via ChangeFSI (v1.38) it crashes.

The image you linked to seems to use local colour tables, and ChangeFSI doesn’t look to handle those (it does support global colour tables, however). It then tries to interpret the unexpected table as an LZW bitstream and explodes.

I’ve added support for local colour tables , can you see if this fixes your problem?

Jun 18, 2013 11:49am

Rick Murray (539) 13850 posts

Err… Isn’t GIF a chunk format and you’re supposed to ignore chunks you don’t understand/support?

Jun 18, 2013 6:42pm

Malcolm Hussain-Gambles (1596) 811 posts

That fixes the problem indeed! Great (I am a little suspicious how fast you managed to turn that around, are you actually human or some kind of demi-god?)
Either way, if I bump into you at a RISC OS show I owe you a big cake of your choosing!
I first ran my program on the off chance that there were some of those GIF’s and tonight it seems there are a couple.
ChangeFSI (original) fell over in a really nasty way.
Replaced with the updated ChangeFSI and no issues, all converted no problems!
Also I tried that example gif from above.
That crashed nastily with the old version and worked perfectly with the new version.

From what I can see from the licence I am free to distribute this (or a later version) of ChangeFSI with my application as long as I whack the Licence in there with it? With, as in the same archive, not as in embedded into the application.

My application is nearly ready for a preview release ;-)
It’s looking nice, if i do say so myself.
Still a lot of work to do with it, but it’s fully functional at the moment – I just need to find and fix more bugs!

Jun 20, 2013 9:45pm

Malcolm Hussain-Gambles (1596) 811 posts

Will this get pushed into the code base automatically?
Is there anything I can do to help get it in?

Cheers
Malcolm

Jun 27, 2013 8:47pm

Malcolm Hussain-Gambles (1596) 811 posts

http://news.bbcimg.co.uk/media/images/68415000/png/_68415359_mmmgpnedfp2lorenzocrash.png

This one get’s a “This type of file is not recognised by ChangeFSI”
Not a bug, as it appears changefsi doesn’t support png – which is a real shame.

Any chance of png support?
I’d even be willing to fund the development work if needed.

ChangeFSI Bug

Reply

Search forums

Social

ROOL Store

Donate! Why?

RISC OS IPR

Description

Voices

Options

Jun 17, 2013 7:28pm Malcolm Hussain-Gambles (1596) 811 posts	I’ve found a couple of times that when converting GIF files via ChangeFSI (v1.38) it crashes. And as seems to be usual pain, leaves the file open…grrrr! The GIF file seems fine and it loads fine using !PrivatEye http://news.bbcimg.co.uk/media/images/68163000/gif/_68163045_44944066.gif I think for my app I’ll disable ChangeFSI for GIF files for the moment, I’m only interested in the larger files which always seem to be jpgs anyway.

Jun 18, 2013 7:32am Sprow (202) 1158 posts	I’ve found a couple of times that when converting GIF files via ChangeFSI (v1.38) it crashes. The image you linked to seems to use local colour tables, and ChangeFSI doesn’t look to handle those (it does support global colour tables, however). It then tries to interpret the unexpected table as an LZW bitstream and explodes. I’ve added support for local colour tables , can you see if this fixes your problem?

Jun 18, 2013 11:49am Rick Murray (539) 13850 posts	Err… Isn’t GIF a chunk format and you’re supposed to ignore chunks you don’t understand/support?

Jun 18, 2013 6:42pm Malcolm Hussain-Gambles (1596) 811 posts	That fixes the problem indeed! Great (I am a little suspicious how fast you managed to turn that around, are you actually human or some kind of demi-god?) Either way, if I bump into you at a RISC OS show I owe you a big cake of your choosing! I first ran my program on the off chance that there were some of those GIF’s and tonight it seems there are a couple. ChangeFSI (original) fell over in a really nasty way. Replaced with the updated ChangeFSI and no issues, all converted no problems! Also I tried that example gif from above. That crashed nastily with the old version and worked perfectly with the new version. From what I can see from the licence I am free to distribute this (or a later version) of ChangeFSI with my application as long as I whack the Licence in there with it? With, as in the same archive, not as in embedded into the application. My application is nearly ready for a preview release ;-) It’s looking nice, if i do say so myself. Still a lot of work to do with it, but it’s fully functional at the moment – I just need to find and fix more bugs!

Jun 20, 2013 9:45pm Malcolm Hussain-Gambles (1596) 811 posts	Will this get pushed into the code base automatically? Is there anything I can do to help get it in? Cheers Malcolm

Jun 27, 2013 8:47pm Malcolm Hussain-Gambles (1596) 811 posts	http://news.bbcimg.co.uk/media/images/68415000/png/_68415359_mmmgpnedfp2lorenzocrash.png This one get’s a “This type of file is not recognised by ChangeFSI” Not a bug, as it appears changefsi doesn’t support png – which is a real shame. Any chance of png support? I’d even be willing to fund the development work if needed.