EtherK EKFlowControl can't be configured

“*Configure EKFlowControl 0 None” should work, instead it reports a syntax error. Looking at the EtherK module source for ek_cli_flow(), it doesn’t skip past the first argument correctly:

e = parse_unit_num(&arg_string, &unit);
if (e != NULL)
return e;

while (*arg_string == ’ ’)
arg_string++;

Should it not be using OS_SubstituteArgs as all the other config. parameters use to skip the unit no?

it doesn’t skip past the first argument correctly

Turns out it does, because parse_unit_num() updates arg_string by virtue of using OS_ReadUnsigned. However, the main problem is assuming that the parameter string is null terminated – of course it’s not it’s either space or CR terminated, and strcmp() doesn’t match on that.

Fixed in EtherK 0.25.

Thanks for fixing that, I’ll grab the build and give it a go.