Module-is-32-bit test code?

Hi, I was looking at the 32 bit testing performed during module load for a reply to DavidS and…

 [ No26bitCode
20      TST     R3, #3
        BNE     %FT88
21      CMP     R3, R2
        MOVLO   PC, lr
88
        ADR     R0, ErrorBlock_RMNot32bit
      [ International
        MOV     R3, R4
        LDR     R4, [R1, #Module_Title]
        ADD     R4, R1, R4
        BL      TranslateError_UseR4
        MOV     R4, R3
      |
        SETV
      ]
        Pull   "R3, PC"
        MakeErrorBlock RMNot32bit
 ]

        MakeErrorBlock BadRMHeaderField

…Sources.Kernel.s.ModHand lines 2206 to 2226.

Shouldn’t the MakeErrorBlock RMNot32bit come before the instruction to Pull PC?

Shouldn’t the MakeErrorBlock RMNot32bit come before the instruction to Pull PC?

You think executing an error block is a good idea? :)

If you look a little closer:

ADR     R0, ErrorBlock_RMNot32bit
BL      TranslateError_UseR4
Pull   "R3, PC"

TranslateError will look up the error message using MessageTrans and set the V flag, returning an updated error block pointer in R0. The Pull will then return to the caller.

<rummage> <rummage> Damn these macros! ;-)

I thought MakeErrorBlock was code, not data.