Forums → Bugs →

localtime() is broken [might be Territory?]

79 posts, 13 voices

Pages: 1 2 3 4

Apr 25, 2016 9:11pm

Rick Murray (539) 13850 posts

I will need to test the following combinations (if supported) to ensure that behaviour is no worse than before:

Program	Library
APCS-R	Existing
APCS-R	“Fixed”
APCS-neutral	Existing
APCS-neutral	“Fixed”
APCS-32	Existing
APCS-32	“Fixed”

I do not have RISC OS 4.xx – so could somebody please test the library and programs? I have put together a mini test suite here containing the “fixed” library, plus the TimeFiddle program in various guises.

How to test :

Boot your machine.

Immediately spam the Esc key to abort the regular boot.

Run the applicable software for your machine.
The “TimeFiddle” program is provided in the following formats:
- APCS-R (26 bit only, compiled with C v3)
- APCS-R2 (hacked so no longer uses BLNV as a NOP in APCS header; modern machines think that’s a BLX)
- APCS-N (26/32 bit, compiled with C v5.51 (2002); should work on everything)
- APCS-32 (compiled with C v5.71 (2014) with -arch 5; so behaviour on RiscPC era machines is not currently known (I’ll test it on the emulator tomorrow))

The output will be something like this:

gmtime() says    : Mon Apr 25 20:48:07 2016
localtime() says : Mon Apr 25 22:48:07 2016

The first line will be the time in UTC, the second will be the time in your local time (+1 for most of you in BST; +2 for me in CEST).

For a proper test, if you live in the UK, please *Configure GMT and run it again to check that the times reported are the same (local = GMT). Don’t forget to *Configure BST afterwards. ;-)

You have finished testing the built-in ROM version of CLib.

Now *RMLoad CLib2632 to softload the ‘fixed’ version…
Do *Help SharedCLibrary to verify that the fixed version is loaded. It identifies as 5.88 (29 Feb 2016).

Repeat the above tests.
The results should be identical for UK residents.

For those using a hacked UK territory to provide European time, or in multi-zone territories (such as USA), the results on RISC OS 5 will differ:
- The ROM module CLib will provide you with the timezone offset of the first timezone it encounters regardless of whether or not this is the correct timezone.
- The ‘fixed’ module should provide you with a working localtime() function that returns the correct time for your timezone, even if you’re the ‘n’th zone in the list – like Alaskan summer time (if such a thing as summer in Alaska is even conceivable…).

When done, you should probably reboot.

I will perform the test on the following systems tomorrow or Wednesday:

RISC OS 3.50 (RedSquirrel; GMT/BST – needs CallASWI)
RISC OS 3.60 (RedSquirrel; GMT/BST – hopefully; I have ROM images but haven’t booted it; may need CallASWI?)
RISC OS 3.70 (RedSquirrel; GMT/BST)
RISC OS 5.23 (ZPP; GMT/BST)
RISC OS 5.23 (my build; GMT/BST/CET/CEST)

So, if anybody can fill in with RISC OS 4.xx, that would be a great help.

Apr 25, 2016 9:15pm

Rick Murray (539) 13850 posts

Since Jeffrey has built a good 26 bit safe version, I’ll give it a whirl on !A310Emu as well, just, you know, for the lulz. ;-)

If you encounter any problems with my CLib2632, try Jeffrey’s build.

It builds one version of CLib, which supports APCS-R and APCS-32. No need to use archaic versions of the C compiler!

The archaic version of the compiler was not for CLib, it was for something capable of building APCS-R software to run natively on older versions of RISC OS using the ROM CLib…

Thanks for the library.

Apr 26, 2016 9:44pm

Rick Murray (539) 13850 posts

WARNING – long post follows. (^_^)

Edit Billion-1: B*^&%y Textile…!

Order of tests:

Using ROM CLib:
- Test using all supported APCS versions of the platform (usually just APCS-R) in GMT (times should be equal) and BST (localtime should be an hour ahead)
Load ‘fixed’ CLib:
- Repeat previous tests; note that later CLib can load more than just APCS-R on older platforms.

In these tests:

TF-APCSR is the test program built using 26 bit era tools.
TF-APCSN is the test program built to be 26/32 neutral using ~2002 vintage tools.
TF-APCS32 is the test program built to be 32 bit, for ARMv6, using the current DDE. It runs on RISC OS 3.10 anyway…hmmm…
And finally:
CLibJ is the ‘fixed’ CLib that Jeffrey built. Mine has ‘issues’ with pre-RiscPC machines.

All machines tested were emulated.

RISC OS 3.10

Tested on an A310 emulator running within a RiscPC emulator. Can you say slow!?!? ;-)
Interesting that it works. Perhaps the DST flag was retconned into the CMOS allocations after the PRM went to press?

*Help UtilityModule
==> Help on keyword UtilityModule
Module is: MOS Utilities        3.11 (29 Sep 1992)

Commands provided:
Configure       Echo    Error   Eval    GOS     IF      Ignore  Modules RMClear
RMEnsure        RMFaster        RMInsert        RMKill  RMLoad  RMReInit
RMRun   RMTidy  ROMModules      Set     SetEval SetMacro        Show    Status
Time    Unplug  Unset

It has help on:
Break   Commands        FileCommands    PowerOn Reset   Syntax
*Help SharedCLibrary
==> Help on keyword SharedCLibrary
Module is: C Library    3.99 (23 Apr 1992)
*Configure GMT
*Configure Timezone 0
*Time
Fri,26 Apr 1996.20:25:56
*TF-APCSR
gmtime() says    : Fri Apr 26 20:26:04 1996
localtime() says : Fri Apr 26 20:26:04 1996
*TF-APCSN
Shared C library is out of date
*Configure BST
*TF-APCSR
gmtime() says    : Fri Apr 26 20:26:15 1996
localtime() says : Fri Apr 26 21:26:15 1996
*Configure GMT
*RMLoad CallASWI
*RMLoad CLibJ
*Help SharedCLibrary
==> Help on keyword SharedCLibrary
Module is: C Library    5.88 (29 Feb 2016)
*TF-APCSR
gmtime() says    : Fri Apr 26 20:26:45 1996
localtime() says : Fri Apr 26 20:26:45 1996
*TF-APCSN
gmtime() says    : Fri Apr 26 20:26:48 1996
localtime() says : Fri Apr 26 20:26:48 1996
*TF-APCS32
gmtime() says    : Fri Apr 26 20:26:52 1996
localtime() says : Fri Apr 26 20:26:52 1996
*Configure BST
*TF-APCSR
gmtime() says    : Fri Apr 26 20:27:03 1996
localtime() says : Fri Apr 26 21:27:03 1996
*TF-APCSN
gmtime() says    : Fri Apr 26 20:27:06 1996
localtime() says : Fri Apr 26 21:27:06 1996
*TF-APCS32
gmtime() says    : Fri Apr 26 20:27:09 1996
localtime() says : Fri Apr 26 21:27:09 1996
*