Filer and ZeroPage

18th July ROM and ZeroPain module give the follow error log information when a Filer window has input focus and no item is selected and CTRL-k (delete object) is pressed.

Time: Wed Jul 22 20:45:22 2015
Location: Unknown
Current Wimp task: Unknown
Last app to start: Filer_Action

R0  = 00000000 R1  = 80000113 R2  = 60000000 R3  = fa207b00
R4  = fa207b00 R5  = fa207f00 R6  = fa207f74 R7  = fa207f7c
R8  = 00000029 R9  = 2408c9f4 R10 = 00000013 R11 = 00000025
R12 = 80000113 R13 = fa207ac0 R14 = 80000113 R15 = fc01ec30
DFAR = 00000000  Mode SVC32  Flags Nzcv if   PSR = 80000113

fc01ebe8 : e3a0c000 : MOV     R12,#0
fc01ebec : e35a002d : CMP     R10,#&2D           ; ="-"
fc01ebf0 : 03e0c000 : MVNEQ   R12,#0
fc01ebf4 : 135a002b : CMPNE   R10,#&2B           ; ="+"
fc01ebf8 : 02811001 : ADDEQ   R1,R1,#1
fc01ebfc : e3a00000 : MOV     R0,#0
fc01ec00 : ef020021 : SWI     XOS_ReadUnsigned
fc01ec04 : e35c0000 : CMP     R12,#0
fc01ec08 : 42622000 : RSBMI   R2,R2,#0
fc01ec0c : e49df004 : LDR     PC,[R13],#4
fc01ec10 : e10f1000 : MRS     R1,CPSR
fc01ec14 : e3811003 : ORR     R1,R1,#3
fc01ec18 : e3c110c0 : BIC     R1,R1,#&C0         ; ="À"
fc01ec1c : e121f001 : MSR     CPSR_c,R1
fc01ec20 : e202220e : AND     R2,R2,#&E0000000
fc01ec24 : e52d0004 : STR     R0,[R13,#-4]!
fc01ec28 * e4d01001 * LDRB    R1,[R0],#1
fc01ec2c : e351000d : CMP     R1,#&0D            ; =13
fc01ec30 : 1351000a : CMPNE   R1,#&0A            ; =10
fc01ec34 : 13510000 : CMPNE   R1,#0
fc01ec38 : 049d0004 : LDREQ   R0,[R13],#4
fc01ec3c : 0a000007 : BEQ     &FC01EC60
fc01ec40 : e331003c : TEQ     R1,#&3C            ; ="<"
fc01ec44 : 1afffff7 : BNE     &FC01EC28
fc01ec48 : e49d0004 : LDR     R0,[R13],#4
fc01ec4c : e59fc044 : LDR     R12,&FC01EC98
fc01ec50 : e5dc1300 : LDRB    R1,[R12,#768]
fc01ec54 : e201107f : AND     R1,R1,#&7F         ; =127
fc01ec58 : e5cc1300 : STRB    R1,[R12,#768]
fc01ec5c : e1822981 : ORR     R2,R2,R1,LSL #19
fc01ec60 : e2222202 : EOR     R2,R2,#&20000000
fc01ec64 : e4d01001 : LDRB    R1,[R0],#1

--------------------------------------------------------------------------------

Time: Wed Jul 22 20:45:22 2015
Location: Unknown
Current Wimp task: Unknown
Last app to start: Filer_Action

R0  = 00000000 R1  = 00000000 R2  = 40000000 R3  = fa207b00
R4  = fa207b00 R5  = fa207f00 R6  = fa207f74 R7  = fa207f7c
R8  = 00000029 R9  = 2408c9f4 R10 = 00000013 R11 = 00000025
R12 = 80000113 R13 = fa207ac4 R14 = 80000113 R15 = fc01ec6c
DFAR = 00000000  Mode SVC32  Flags nZCv if   PSR = 60000113

fc01ec24 : e52d0004 : STR     R0,[R13,#-4]!
fc01ec28 : e4d01001 : LDRB    R1,[R0],#1
fc01ec2c : e351000d : CMP     R1,#&0D            ; =13
fc01ec30 : 1351000a : CMPNE   R1,#&0A            ; =10
fc01ec34 : 13510000 : CMPNE   R1,#0
fc01ec38 : 049d0004 : LDREQ   R0,[R13],#4
fc01ec3c : 0a000007 : BEQ     &FC01EC60
fc01ec40 : e331003c : TEQ     R1,#&3C            ; ="<"
fc01ec44 : 1afffff7 : BNE     &FC01EC28
fc01ec48 : e49d0004 : LDR     R0,[R13],#4
fc01ec4c : e59fc044 : LDR     R12,&FC01EC98
fc01ec50 : e5dc1300 : LDRB    R1,[R12,#768]
fc01ec54 : e201107f : AND     R1,R1,#&7F         ; =127
fc01ec58 : e5cc1300 : STRB    R1,[R12,#768]
fc01ec5c : e1822981 : ORR     R2,R2,R1,LSL #19
fc01ec60 : e2222202 : EOR     R2,R2,#&20000000
fc01ec64 * e4d01001 * LDRB    R1,[R0],#1
fc01ec68 : e3510020 : CMP     R1,#&20            ; =" "
fc01ec6c : 0afffffc : BEQ     &FC01EC64
fc01ec70 : e3120102 : TST     R2,#&80000000
fc01ec74 : 03510022 : CMPEQ   R1,#&22            ; ="""
fc01ec78 : 12400001 : SUBNE   R0,R0,#1
fc01ec7c : 03822201 : ORREQ   R2,R2,#&10000000
fc01ec80 : e351000d : CMP     R1,#&0D            ; =13
fc01ec84 : 1351000a : CMPNE   R1,#&0A            ; =10
fc01ec88 : 13510000 : CMPNE   R1,#0
fc01ec8c : 038ee101 : ORREQ   R14,R14,#&40000000
fc01ec90 : 13cee101 : BICNE   R14,R14,#&40000000
fc01ec94 : eabf51b9 : B       &FAFF3380
fc01ec98 : faf45800 : BLX     &FBD34CA0          ; ARMv5 of hoger
fc01ec9c : e10fa000 : MRS     R10,CPSR
fc01eca0 : e38aa003 : ORR     R10,R10,#3

--------------------------------------------------------------------------------

Time: Wed Jul 22 20:45:22 2015
Location: Unknown
Current Wimp task: Unknown
Last app to start: Filer_Action

R0  = 00000000 R1  = 00000000 R2  = 40000000 R3  = fa207b00
R4  = fa207b00 R5  = fa207f00 R6  = fa207f74 R7  = fa207f7c
R8  = 00000029 R9  = 2408c9f4 R10 = 00000000 R11 = 00000026
R12 = 80000113 R13 = fa207ac4 R14 = 80000113 R15 = fc01ecc4
DFAR = 00000000  Mode SVC32  Flags nZcv if   PSR = 40000113

fc01ec7c : 03822201 : ORREQ   R2,R2,#&10000000
fc01ec80 : e351000d : CMP     R1,#&0D            ; =13
fc01ec84 : 1351000a : CMPNE   R1,#&0A            ; =10
fc01ec88 : 13510000 : CMPNE   R1,#0
fc01ec8c : 038ee101 : ORREQ   R14,R14,#&40000000
fc01ec90 : 13cee101 : BICNE   R14,R14,#&40000000
fc01ec94 : eabf51b9 : B       &FAFF3380
fc01ec98 : faf45800 : BLX     &FBD34CA0          ; ARMv5 of hoger
fc01ec9c : e10fa000 : MRS     R10,CPSR
fc01eca0 : e38aa003 : ORR     R10,R10,#3
fc01eca4 : e3caa0c0 : BIC     R10,R10,#&C0       ; ="À"
fc01eca8 : e121f00a : MSR     CPSR_c,R10
fc01ecac : e3cee202 : BIC     R14,R14,#&20000000
fc01ecb0 : e3a0a000 : MOV     R10,#0
fc01ecb4 : e3120302 : TST     R2,#&08000000
fc01ecb8 : 1a0000a0 : BNE     &FC01EF40
fc01ecbc * e4d01001 * LDRB    R1,[R0],#1
fc01ecc0 : e351000d : CMP     R1,#&0D            ; =13
fc01ecc4 : 1351000a : CMPNE   R1,#&0A            ; =10
fc01ecc8 : 13510000 : CMPNE   R1,#0
fc01eccc : 0a000066 : BEQ     &FC01EE6C
fc01ecd0 : e3510020 : CMP     R1,#&20            ; =" "
fc01ecd4 : 0a000075 : BEQ     &FC01EEB0
fc01ecd8 : ba0000a5 : BLT     &FC01EF74
fc01ecdc : e3510022 : CMP     R1,#&22            ; ="""
fc01ece0 : 0a000076 : BEQ     &FC01EEC0
fc01ece4 : e351007c : CMP     R1,#&7C            ; ="|"
fc01ece8 : 03120101 : TSTEQ   R2,#&40000000
fc01ecec : 0a00007e : BEQ     &FC01EEEC
fc01ecf0 : e351003c : CMP     R1,#&3C            ; ="<"
fc01ecf4 : 1a00006f : BNE     &FC01EEB8
fc01ecf8 : e92d4005 : STMDB   R13!,{R0,R2,R14}

--------------------------------------------------------------------------------

18th July ROM and ZeroPain module give the follow error log information when a Filer window has input focus and no item is selected and CTRL-k (delete object) is pressed.

Just when Ctrl-K is pressed or also when the menu option is used?

Checked the ROM for this code. First two aborts are in the kernel GSINIT routine (source s.Arthur2), third abort occurs in the kernel GSRead routine.

Only when Ctrl-K is pressed. As it only occurs when no item is selected, it is not possible to use the menu option as it’s greyed out.

As it only occurs when no item is selected, it is not possible to use the menu option as it’s greyed out.

I think my minds having a night off. Should have remembered that.

The keypress route is directly driving the DecodeMenu_File_Delete option but that isn’t checking for null values for the “selected” objects.
Shortcuts for other options like rename would probably do the same if you had them.

Checked the keypress code of the Filer. Didn’t know there are so many key short-cuts. Do you know why they aren’t added to the Filer menu messages?

When I tested the short-cuts I found another abort. When using BACK or CTRL-H (not the menu option) and the parent dir is already opened ZeroPain reports:

Time: Thu Jul 23 14:03:05 2015
Location: Offset 00009104 in module Filer
Current Wimp task: Filer
Last app to start: Filer_Action

R0  = 20271860 R1  = 20052074 R2  = fc237cca R3  = 000002c6
R4  = 000003de R5  = 00000000 R6  = 000000ee R7  = 00000000
R8  = 00000000 R9  = 000002e0 R10 = 000000ee R11 = 000002e0
R12 = 202717b4 R13 = 202728f0 R14 = fc2399d8 R15 = fc23ce7c
DFAR = 00000008  Mode USR32  Flags nzcv if   PSR = 00000110

fc23ce34 : 23a00000 : MOVCS   R0,#0
fc23ce38 : eafffb61 : B       &FC23BBC4
fc23ce3c : e5910000 : LDR     R0,[R1,#0]
fc23ce40 : e3550105 : CMP     R5,#&40000001
fc23ce44 : 049df004 : LDREQ   PC,[R13],#4
fc23ce48 : e58c0060 : STR     R0,[R12,#96]
fc23ce4c : ebffe654 : BL      &FC2367A4
fc23ce50 : e59c0070 : LDR     R0,[R12,#112]
fc23ce54 : e59c1074 : LDR     R1,[R12,#116]
fc23ce58 : e58c00e4 : STR     R0,[R12,#228]
fc23ce5c : e58c10e8 : STR     R1,[R12,#232]
fc23ce60 : ebffe32f : BL      &FC235B24
fc23ce64 : e49df004 : LDR     PC,[R13],#4
fc23ce68 : e52df004 : STR     PC,[R13,#-4]!      ; *** Kan PC+8 of PC+12 bewaren
fc23ce6c : ebfffd4c : BL      &FC23C3A4
fc23ce70 : e1a00000 : MOV     R0,R0
fc23ce74 * 75970008 * LDRVC   R0,[R7,#8]
fc23ce78 : 7b000021 : BLVC    &FC23CF04
fc23ce7c : e49df004 : LDR     PC,[R13],#4
fc23ce80 : e5941000 : LDR     R1,[R4,#0]
fc23ce84 : e3510105 : CMP     R1,#&40000001
fc23ce88 : 059c1008 : LDREQ   R1,[R12,#8]
fc23ce8c : e5940008 : LDR     R0,[R4,#8]
fc23ce90 : e1510004 : CMP     R1,R4
fc23ce94 : 0a000004 : BEQ     &FC23CEAC
fc23ce98 : ebffe2e8 : BL      &FC235A40
fc23ce9c : 6bffdee3 : BLVS    &FC234A30
fc23cea0 : e5910008 : LDR     R0,[R1,#8]
fc23cea4 : eb000016 : BL      &FC23CF04
fc23cea8 : e49df004 : LDR     PC,[R13],#4
fc23ceac : ebffe2e3 : BL      &FC235A40
fc23ceb0 : e49df004 : LDR     PC,[R13],#4

Code abort occurs when loading ‘d_handle’ in function key_open_parent from s.KeyPress

Looks very similar to three I reported a few weeks ago:

https://www.riscosopen.org/forum/forums/1/topics/3418?page=3#posts-44756

Does GSREAD need input validation? I couldn’t track down what was triggering 512kb of these on every boot – without a stack trace its near impossible.

Checked the keypress code of the Filer. Didn’t know there are so many key short-cuts. Do you know why they aren’t added to the Filer menu messages?

There’s a fair number of unfinished items in the code in 2.39.
More for my own education than anything I’m fiddling with activating various of those shortcuts, and others (Ctrl-D or Insert for new directory in focus directory for example¹)
F1 for Help, Return for run selected object…
The main issue is not what key does what, more a case of clean code to make it do the job.

The Ctrl-D matches Q-Filer, Insert matches RO6. F1 is help in other bits, seems logical to use F1 again. I like the idea in RO6 of using DEL for delete, particularly when used with Fred’s Transient and TrapDelete as you then have simple DEL items going into the recycle facility with available restore and Shift-Del is a permanent, kiss it goodbye deletion.

Important keypresses should perhaps not be on single keys – too easy to press by mistake…

Important keypresses should perhaps not be on single keys – too easy to press by mistake…

Any particular keys /functions in mind? The thing being that the keys I’m using in this version match keys used elsewhere. F5 for refresh, F1 for !Help (sh-F1 would be Info)
I’m not really treading new ground.

Hmmm, looking on Fred’s site I notice he doesn’t seem to have Transient 2.08 available so the difference between Del and Shift-Del functionality becomes nil.
Delete and Sh-Delete produce the same value but TrapDelete is checking for the state of the shift key to be able to force a full delete (just like PC systems, and I think RO6)

These aborts should now be fixed with Filer 2.41. Thanks for reporting them!

Thanks for the quick fix. Tried latest ROM. Reported problems are gone.
:-)