Shift-click on pinboard bug
Andrew Rawnsley (492) 1445 posts |
I’m not sure if others can reproduce this one – it was mentioned to me by a customer, and I am Put an application on the pinboard, and then try to shift-double click the pinboard icon to Shift double click in filer is OK. Problem exists in 3rd party pinboard replacement, too. I’m told that pinboard replacement simply uses INKEY to check for shift – I haven’t checked if Anyway, it seems like an odd one – a bit of a “biggy” to have slipped through (which makes me Definately goes back to early August, probably longer. Doesn’t seem to be an issue back in Feb. |
Chris Johnson (125) 825 posts |
I can confirm that the SHIFT is NOT recognised on the PandaRO here, but is recognised on the Iyonix. Both machines are on RISC OS 5.23, the PB is very recent, but the Iyonix is from back in June. ARMX6 is not on at the moment, but could check later. |
Rick Murray (539) 13840 posts |
I noticed that. Wanting to shift-open a buggy program in an editor to look at the code, Pinboard ran the file instead (and crashed the machine, Yay). So, yes, Pinboard in the Pi doesn’t register Shift… |
Frederick Bambrough (1372) 837 posts |
Same applies to click click hold. BB -xM. |
Sprow (202) 1158 posts |
Nearly, it’s Filer_Run, and that’s the key bit. This looks like a latent bug from fixing ticket #400 in Filer 2.40 at the end of July.
Not sure it counts as a biggy, but certainly highlights that there could be less talking and more people testing the nightly builds. Or, those who are testing don’t pin stuff on the Pinboard, like me. |
Steve Pampling (1551) 8170 posts |
Yup. That and fiddling with Filer keyboard shortcuts and therefore not looking at pinboard.
That link reminds me – what time of day does the bug tracker actually work? |
Rick Murray (539) 13840 posts |
Or those we do don’t feel like spawning messages to report minor things. After all, there’s a bug tracker for that. Oh, wait… |
David Pitt (102) 743 posts |
Fixed, as tested with Pi ROM 2015-09-30. Many thanks. |
Andrew Rawnsley (492) 1445 posts |
Just to follow this up, I’m still getting people complaining about side effects following the fix in Filer 2.40 mentioned by Sprow above. Basically, any “pinboard-like” app which previously allowed shift-double behaviour is effectively broken. This includes things like Blinds, MenuBar etc and presumably any other non-maintained 3rd party pinboard-type tools. Possibly also things like StrongMen and Director, although I must admit that I haven’t tried those. I’m not sure there’s a solution, particularly, but this does smack of being a somewhat heavy-handed fix for a problem that didn’t affect too many people. I suspect that altering Alarm, for example, to call Filer_Run with a -noshift check would have been better than a global change to how Filer_Run (a fairly fundamental call) works. Is there a recommended way to advise coders to alter their software, or to change the default behaviour? |
Rick Murray (539) 13840 posts |
Fix Pinboard instead? |