You are currently browsing the Subversion repository.
Changesets can be listed by changeset number.
The Git repository is here.

Changesets
» Changeset 191

Changeset 191

Removed the login_hop mechanism. It was crude and only Typo used it;
the Typo 4.1 integration has taken a cleaner approach that removes the
requirement for the feature.

Renamed the 'logged out' image to a more logical name. The application
controller now caches the logged in and out images. When using FCGI or
a comparable execution model for Hub, this means that the images only
get loaded once and are thereafter served from RAM.

Comitted by: rool
Date: Wednesday April 04 18:32:37 2007 (over 17 years ago)

Affected files:

rool/rails/hub/trunk/public/images/icons/logged_out.png
rool/rails/hub/trunk/public/images/icons/not_logged_in.png
rool/rails/hub/trunk/app/controllers/account_controller.rb (diff)

rool/rails/hub/trunk/app/controllers/account_controller.rb:

prev.	current


		layout 'default.rhtml'

	5	# Cache the logged in and out PNG images in RAM; they're only small.
	6
	7	@@logged_in_image = File.read("#{LOGIN_ICONS}/logged_in.png")
	8	@@logged_out_image = File.read("#{LOGIN_ICONS}/logged_out.png")
	9
		# Action permissions for this class as a class variable, exposed
		# to the public through a class method.

...	...
		# even if the HTML stays cached.
		#
		def login_indication
380		~~file = "#{LOGIN_ICONS}#{hubssolib_logged_in? ? '/logged_in.png' : '/not_logged_in.png'}"~~
381
		@headers['Pragma'] = 'no-cache'
		@headers['Cache-Control'] = 'no-cache, must-revalidate'

385		~~send_file file,~~
	388	send_data hubssolib_logged_in? ? @@logged_in_image : @@logged_out_image,
		:type => 'image/png',
		:disposition => 'inline'
		end
...	...
		end
		end

409		~~# The login_hop method is also unusual; it redirects to the login page~~
410		~~# if the user is logged out, or the tasks page if the user is logged in.~~
411		~~# For logging in, an attempt is made to remember the previous URL by HTTP~~
412		~~# 'referer' header, with the redirection post-login/logout set to go back~~
413		~~# to that page.~~
414		#
415		~~# The idea is that a caller which caches HTML can provide a link to this~~
416		~~# method which redirects to a more relevant location depending on the~~
417		~~# user login status.~~
418		#
419		~~def login_hop~~
420		~~ret = request.env["HTTP_REFERER"]~~
421
422		~~if hubssolib_logged_in?~~
423		~~if (ret && !ret.empty?)~~
424		~~uri = URI.parse(ret)~~
425
426		~~# There's a Referer header; did it come from an SSL connection? If~~
427		~~# so redirect to the control panel. If not, perhaps the only reason~~
428		~~# the user got bounced to the login_hop method was because they were~~
429		~~# logged in but had dropped back to HTTP, thus hiding their login~~
430		~~# state. Redirect back to the referer, but with HTTPS. Should they~~
431		~~# in turn bounce here again, we'll be over HTTPS this time, so will~~
432		~~# go onto the control panel.~~
433
434		~~if (uri.scheme == 'https')~~
435		~~redirect_to :controller => 'tasks', :action => nil~~
436		~~else~~
437		~~hubssolib_set_flash(:attention, "You were logged in, but using an insecure connection to the web site. You've been moved onto a secure connection and may not need to log in again as a result.")~~
438		~~redirect_to hubssolib_promote_uri_to_ssl(ret)~~
439		~~end~~
440		~~else~~
441
442		~~# There's no Referer header. We're logged in; show the control~~
443		~~# panel.~~
444
445		~~redirect_to :controller => 'tasks', :action => nil~~
446		~~end~~
447		~~else~~
448
449		~~# Try to store the referer header for future reference (won't work~~
450		~~# unless we're over HTTPS, but the HubSsoLib deals with some~~
451		~~# redirections related to that) and go to the login page.~~
452
453		~~hubssolib_store_location(ret) if (ret && !ret.empty?)~~
454		~~redirect_to :action => 'login'~~
455		~~end~~
456		~~end~~
457
		protected

		# Pass a HubSsoLib::User object. Returns an equivalent User Model object.

Changeset 191

Affected files:

rool/rails/hub/trunk/app/controllers/account_controller.rb:

Search tickets

Social

ROOL Store

Donate! Why?

RISC OS IPR

Options

RSS feeds