Changesets can be listed by changeset number.
The Git repository is here.
Changeset 261
Moved sanity checks of enumerated current site users from the Hub
application into the library gem, where it always should have been.
Explicitly check to see if the session details returned by the DRb
server "look" like a User representation by checking that the
session proxy responds to "user_id". This always *should* be the
case but on the ROOL production site, there have been numerous
times when the DRb process seems to serve up odd objects which do
not respond as expected, leading to an application error if the
administrator tries to use the enumeration action.
- Comitted by: rool
- Date: Wednesday February 25 21:22:14 2009 (over 15 years ago)
Affected files:
rool/rails/gems/hubssolib/trunk/lib/hub_sso_lib.rb (diff)
-
rool/rails/hub/trunk/app/controllers/account_controller.rb (diff)
rool/rails/gems/hubssolib/trunk/lib/hub_sso_lib.rb:
| prev. | current | |
| users = [] | ||
| sessions.each do |key, value| | ||
| 1192 | | |
| 1192 | user = value.session_user | |
| 1193 | users.push(user) if (user && user.respond_to?(:user_id) && user.user_id) | |
| end | ||
| return users |
rool/rails/hub/trunk/app/controllers/account_controller.rb:
| prev. | current | |
| # internal users. | ||
| users.each do |user| | ||
| 319 | | |
| 319 | @users.push(to_real_user(user)) | |
| end | ||
| count = @users.length |
