Changesets can be listed by changeset number.
The Git repository is here.
Changeset 414
Further nasty regular expression work, to patch up diff output so that it
doesn't try to self-close DIV tags. Since the system works internally with
XHTML but pages are served as if HTML to prevent browsers choking on the
unusual data type, self-closing elements are ignored - esentially the
browser views the "/>" closing the tag as a small syntax error. With DIVs,
this can lead to big problems when diffs are viewed; the diff engine
canonicalises empty DIV containers, such as those used for automatic tables
of contents and turns them into self-closing elements, which browsers then
think are still *open* when rendering the page. The result is a bit of a
mess. Anyway, replacing self-closing DIVs with normal HTML container style
syntax works around the issue.
- Comitted by: rool
- Date: Monday March 21 17:37:41 2011 (over 13 years ago)
Affected files:
rool/rails/instiki/trunk/lib/page_renderer.rb:
| prev. | current | |
| diffs = '' | ||
| diff_doc.write(diffs, -1, true, true) | ||
| 68 | | |
| 68 | diffs.gsub(/\A<div class='xhtmldiff_wrapper'>(.*)<\/div>\Z/m, '\1').gsub(/(<div[^>]+?)\s*?\/>/, "\\1></div>").html_safe | |
| rescue | ||
| ... | ... | |
| diffs = "<p><ins class=\"diffins\"><strong>Warning: The current and/or previous revision contained markup errors which prevented proper diff analysis. A guess at markup correction has been made but the diff may not be a truly accurate reflection of the real changes.</strong></ins></p>" | ||
| diff_doc.write(diffs, -1, true, true) | ||
| 93 | | |
| 93 | diffs.gsub(/\A<div class='xhtmldiff_wrapper'>(.*)<\/div>\Z/m, '\1').gsub(/(<div[^>]+?)\s*?\/>/, "\\1></div>").html_safe | |
| rescue | ||
