Ticket #122 (Fixed)Fri Mar 16 13:05:52 UTC 2007
Pinboard RMEnsure ColourTrans excessive
| Reported by: | Martin Avison (27) | Severity: | Minor |
| Part: | RISC OS: General | Release: | |
| Milestone: | RISC OS ROM build complete | Status | Fixed |
Details by Martin Avison (27):
The Pinboard module (v0.84 22 Feb 2007 and probably many, or even all previous versions), when the background is a JPEG (and not a Sprite) issues a multiplicity of commands:
RMEnsure ColourTrans 1.25 Error no good
whever a window is dragged over the background which exposes more of the background.
These can easily be 3 per 1/100 second.
I would suggest that these should be removed, as would seem better to do it once at Pinboard startup and set a flag, which could be tested with much less overhead than issuing an RMEnsure command.
Indeed, as ColourTrans is now at v1.76, and in ROM, perhaps the check is now totally redundant?
Changelog:
Modified by Steve Revill (20) Sun, May 20 2007 - 20:35:27 GMT
We released the sources to the Pinboard module (RiscOS.Sources.Desktop.Pinboard) in the Batch One release so anyone who is interested should be able to fix this bug.
Modified by Steve Revill (20) Sat, June 02 2007 - 22:11:27 GMT
OK. I had a look at the Pinboard and couldn’t find the problems you are reporting to I widened my search to the whole of the RISC OS source tree and it eventually turned out to be that this stuff is in the SpriteExtend module, believe it or not. So I take back the possibility of someone fixing it in the released Pinboard sources!
Modified by Martin Avison (27) Sun, March 30 2008 - 17:02:28 GMT
In the absence of released sources (yet) to SpriteExtend, as an experiment I created a copy of SpriteExtend and NOP’d the instructions which seem to issue the RMensure of ColourTrans.
However, when I loaded the bodged module, it had no efect! This could be because my bodges were wrong, or because it needs loading in some special way, or other modules RMReinit’ing afterwards.
Any suggestions?
Modified by Ben Avison (25) Mon, March 31 2008 - 00:36:38 GMT
SpriteExtend was part of Batch Three, though it’s hidden away in the “mixed” part of the source tree due to the presence of IJG (JPEG) source code:
mixed/RiscOS/Sources/Video/Render/SprExtend
Modified by Ben Avison (25) Mon, March 31 2008 - 00:47:51 GMT
Actually, scratch that, it was back in Batch Two!
Modified by Martin Avison (27) Mon, March 31 2008 - 15:22:53 GMT
Thanks Ben – I thought I had looked everywhere, but obviously not!
The reason my experimental bodge had no effect, is that there seem to be 3 places where an identical RMEnsure is done in SprExt!! And I had not hit the one executed so frequently. I will investigate further (if I can fathom the sources …)
Modified by Steve Revill (20) Fri, October 24 2008 - 12:35:58 GMT
- Milestone changed from Unspecified to RISC OS ROM build complete
Modified by Steve Revill (20) Fri, April 24 2009 - 01:51:59 GMT
- Status changed from Open to Fixed
This has been fixed in the latest SpriteExtend. Someone should reopen this ticket if the problem persists in the Pinboard – we don’t think it will.
