Ticket #157 (Fixed)Tue Nov 13 16:33:13 UTC 2007
cvs web interface can't handle non-ASCII chars in log messages
| Reported by: | Steve Revill (20) | Severity: | Major |
| Part: | Web site: RCVSweb and CVSweb (CVS browsing) | Release: | 3rd public site release |
| Milestone: | Batch Three code release completed | Status | Fixed |
Details by Steve Revill (20):
Characters like hard-space (160) and probably others like pound sign (£) in log messages break our cvs web interface’s brain. These are things which we will get in log files now and again, and have already been used in log files in the past.
We should assume Acorn Latin1 char set for chars above ASCII 127.
See the PDriver logs for an example:
castle/RiscOS/Sources/Printing/Modules/PDModules/VersionNumChangelog:
Modified by Andrew Hodgkinson (6) Wed, March 16 2011 - 19:14:17 GMT
ISTR that Acorn Latin 1 is close enough as makes no difference ISO 8859-1. I may be able to pass the logs through the Ruby iconv library to convert from that into UTF-8. Support for “true” Acorn Latin 1, if there’s a difference to 8859-1 – I just can’t remember anymore, it’s been years since I was familiar with all that – would be a pain since iconv doesn’t know about it AFAICS. It does seem to know LATIN1, but I assume that’s the informal alias for ISO 8859-1.
Modified by Andrew Hodgkinson (6) Wed, March 16 2011 - 19:34:46 GMT
- Status changed from Open to Fixed
- Milestone changed from Unspecified to Batch Three code release completed
- Release changed from Unspecified to 3rd public site release
- Part changed from Web site: Collaboa (bugs and subversion browsing) to Web site: RCVSweb and CVSweb (CVS browsing)
As above, fixed by using iconv to convert from an assumed ISO-8859-1 to UTF-8. Speed impact appears to be negligible.
Modified by Andrew Hodgkinson (6) Fri, August 30 2013 - 02:16:08 GMT
The fix broke images by running all data through the converter, so introduced another bug – the images for graphical revisions would not be served correctly.
See Changeset #434.
