Ticket #329 (Fixed)Sun Dec 02 16:16:57 UTC 2012
Filer commands can give rubbish errors
Reported by: | Martin Avison (27) | Severity: | Normal |
Part: | RISC OS: Module | Release: | |
Milestone: | Status | Fixed |
Details by Martin Avison (27):
Filer commands, if they fail because of an OS_ReadArgs error, will give an error message which contains rubbish. For a simple example, try <code>*Filer_Run xxx yyy</code>
It should say <code>Syntax: *Filer_Run [-NoShift] <file>|<application></code>
But will probably have rubbish where ‘Filer_Run’ should be.
This seems to be because the error message token SFLRUN is compacted, and includes <esc>0 which should be replaced in PrettyPrint by the ‘special field’ which is pointed to by r2. This works for *Help Filer_Run but after an error r2 is not set to the command name (and possibly cannot be), and so whatever is at r2 is included in the message.
Notes:
1. This applies to several of the *Filer_ commands.
2. The problem is in RO4.39, and RO5 up to at least Filer 2.30.
3. I suspect the solution may be to stop using the special field token.
3. Errors which exceed the permitted numbers of parameters are ok, as they failed before OS_Args.
Changelog:
Modified by Sprow (202) Sat, December 15 2012 - 09:44:01 GMT
- Status changed from Open to Fixed
Resources no longer use Token0 for syntax messages.