Ticket #334 (Fixed)Thu Jan 24 00:36:07 UTC 2013
Search results a go-go
| Reported by: | Martin Bazley (331) | Severity: | Minor |
| Part: | Web site: Beast (forum engine; forum pages) | Release: | |
| Milestone: | Status | Fixed |
Details by Martin Bazley (331):
Forum search results (like, say, these ones) seem to have acquired an extra “ago” for posts less than three days old. The dates are given are “4 minutes ago ago”, “11 hours ago ago”, etc.!
Changelog:
Modified by Trevor Johnson (329) Sun, February 17 2013 - 20:54:49 GMT
Could line 31 in rool/rails/beast/trunk/app/views/posts/index.rhtml possibly be to blame?
Modified by Andrew Hodgkinson (6) Mon, February 17 2014 - 09:41:58 GMT
At the time of writing the head revision is 442, which on line 31 says “</small>” – so no :-) not that line. But line 50 almost certainly is to blame.
Modified by Andrew Hodgkinson (6) Mon, February 17 2014 - 09:47:34 GMT
Incidentally that “these ones” link doesn’t link to search results, just your own posts. At the time of reading, none are new enough to have the “ago” text anyway; in any case, anything that routes through the RHTML template that Trevor linked to will risk acquiring the double text. Generally speaking that means that if you see “../forum/posts/…” in the URL, it’ll be running through there.
Modified by Andrew Hodgkinson (6) Mon, February 17 2014 - 09:56:02 GMT
Confirmed that this was the root cause & fixed.
Modified by Andrew Hodgkinson (6) Mon, February 17 2014 - 09:56:19 GMT
- Status changed from Open to Fixed
Thanks for the report.
Modified by Trevor Johnson (329) Thu, February 20 2014 - 08:30:08 GMT
<blockquote>…442, which on line 31 says “</small>” – so no :-) not that line</blockquote>
Well, it <em>was</em> that line before <a href=“https://www.riscosopen.org/tracker/repository/changesets/442#rool_rails_beast_trunk_app_views_topics_show.rhtml”>the addition of these 19 lines</a>! :-p
Thanks for the fix, anyway :-)
