Ticket #369 (Fixed)Sun Dec 08 14:03:44 UTC 2013
Filer_OpenDir switches not handled correctly
| Reported by: | Fred Graute (114) | Severity: | Normal |
| Part: | RISC OS: Module | Release: | |
| Milestone: | Status | Fixed |
Details by Fred Graute (114):
The switches -ss (sort by size) and -st (sort by type) are handled incorrectly. Their function is changed over, -ss works as -st and vice versa. The change occured after 26-10-2013 and is present in the 25-11-2013 (also 07-12-2013) release.
The cause seems to be changing the order of the db_sortmode values for db_sm_type and db_sm_size (in WkspEtc) so that match the order in the sortproctables (in SortDir).
Unfortunately this exposes a bug in how the switches are read and stored. The syntax string at Filer_OpenDir_Accept (In Commands) uses the order -st then -ss. However the fields are stored with fopendir_ss first then fopendir_st.
Switching the fields over should fix this issue.
Changelog:
Modified by Sprow (202) Mon, December 09 2013 - 07:57:06 GMT
- Status changed from Open to Fixed
- Part changed from Unspecified to RISC OS: Module
Well spotted!
Fixed in Filer-2_35.
