Ticket #378 (Fixed)Thu Feb 20 08:28:21 UTC 2014
Extra switch to set button slab true colour
| Reported by: | Sprow (202) | Severity: | Enhancement |
| Part: | RISC OS: Module | Release: | |
| Milestone: | Status | Fixed |
Details by Sprow (202):
The border round buttons is currently hardwired in the Wimp, but could follow suit of the other border colours in being settable by theme designers using (yet) another WimpVisualFlags switch.
Changelog:
Modified by Chris (121) Sat, April 19 2014 - 12:34:05 GMT
Some notes on this:
The current colour switches in WimpVisualFlags are as follows:
| Switch | Default colour* | Button types |
| WindowBorderFaceColour | 0 (White) | Highlight for R1-7. |
| WindowBorderOppColour | 4 (Dark grey) | Shade for R1,R2,R5,R6,R7. |
| MenuBorderFaceColour | 0 (White) | Not used. |
| MenuBorderOppColour | 3 (Mid grey) | Shade for R3,R4. |
- All defined as &RRGGBB
We could in principle re-use some of these for icon button borders. However, a theme designer might well want to make the window borders lighter/darker than those used in buttons, or even different colours altogether. Also, reusing these switches means that we can’t control the ‘face’ colour of buttons (currently wimp colour 1, light grey), nor the colour used in the ‘channel’ for R6 (default) buttons.
I propose adding the following switches to control the colours of icon buttons (i.e., those icons with an ‘R’ value in their validation string):
| Switch | Default colour* | Button types |
| ButtonBorderFaceColour | 0 (White) | Highlight for R1-7. |
| ButtonBorderOppColour | 4 (Dark grey) | Shade for R1,R2,R5,R6,R7. |
| ButtonBorderMidColour | 3 (Mid grey) | Shade for R3,R4. |
| ButtonColour | 1 (Light grey) | Face for R1-7. |
| HighlightColour | 12 (Cream) | Channel colour for R6. |
- All defined as &RRGGBB
Adding these five switches would effectively enable complete control of colours used in themes, since you can already change the background colour of windows and menus by using textures.
Modified by Sprow (202) Sun, July 11 2021 - 14:20:38 GMT
- Status changed from Open to Fixed
Added to Wimp 5.81.
For reference the final set of switches were -ButtonColour -ButtonWellColour -ButtonHighlightColour for the button slabs, and -ButtonBorderFaceColour -ButtonBorderOppColour -ButtonBorderShallowColour for the outlines.
