Ticket #395 (Fixed)Thu Aug 28 12:30:41 UTC 2014
WIMP icon shading (greying out)
| Reported by: | Paul Reuvers (507) | Severity: | Normal |
| Part: | RISC OS: Module | Release: | |
| Milestone: | Status | Fixed |
Details by Paul Reuvers (507):
When greying out a text-and-sprite icon (i.e. setting bit 22 of the icon flags), not only the icon will be shaded, but also the background colour of the text, even when the icon does not have a filled background (i.e. bit 5 is unset). I have observed this undesired behaviour in version 5.20 of RISC OS and it certainly wasn’t present in 5.12 or any earlier release.
Setting bit 22 (i.e. greying out the icon), should select a lighter colour for the text (which it does) and for the background colour (which it does). However, when the icon does not have a background colour, it should leave the background colour of the text unaffected. And this is not what is happening. The background of the text (i.e. the bounding box of the text, not the bounding box of the entire icon) gets a lighter background colour, making the application look awkward.
The behaviour can be spotted for example in !ConfiX.
Changelog:
Modified by Sprow (202) Fri, August 29 2014 - 08:34:05 GMT
- Part changed from RISC OS: General to RISC OS: Module
- Attachment added: Shade,fec
The behavior seems unchanged as far as I can see (I also tested against Wimp 4.15 in RISC OS 4.02), see attached Templates file – simply open this in your favourite template editor.
Are you sure it’s not your *WimpVisualFlags that are wrong? Does
*WimpVisualFlags -RIB -NIBITW
make it look different?
Modified by Paul Reuvers (507) Mon, September 01 2014 - 06:58:44 GMT
Thanks for the test template file, but this is not what I mean.
Add an icon to the last line (i.e. make it a text-and-sprite icon) and see that the text suddenly gets a background, despite the fact that the icon is NOT filled.
This behaviour is different from earlier releases of the OS
This would normally not be a problem, as one can choose the text background colour to be the same as the window background colour.
However, as soon as you grey-out the icon, the background colour of the text is made brighter, whilst the background colour of the window stays the same.
That gives you an unwanted text background fill.
Now that I think of it: this will also be visible if textured window backgrounds are used.
Is this perhaps the reason why the native RISC OS configure plug-ins never use sprite-and-text icons?
In the instances that I’ve checked, they have used a separate icon for the sprite and a separate one for the text.
Modified by Sprow (202) Tue, September 02 2014 - 09:01:13 GMT
- Summary changed from Bug in WIMP icon shading (greying out) to WIMP icon shading (greying out)
Does this template file illustrate the problem?
The only difference I can see is that the filled background is lightened too when shaded (which it was not on Wimp 3.69 (in 3.71) nor Wimp 4.15 (in 4.02) but is in Wimp 5.30 (in 5.20)).
The non filled background looks the same to me in all 3 cases.
Modified by Sprow (202) Tue, September 02 2014 - 09:01:42 GMT
- Attachment added: TextPlusIcon,fec
Hmm, retry with the attachment!
Modified by Paul Reuvers (507) Wed, September 03 2014 - 12:55:56 GMT
Yes, that is exactly what I mean. The last icon in your example shows the effect. IMO the background of the last example should not be lightened as the background is not filled (i.e. bit 5 of the iconflags is clear).
I would say this is an undesired effect for the following reasons:
- It didn’t work like that before,
- I specifically asked the background not to be altered (bit 5 off),
- it does not happen on a text-only icon,
- worse of all, it make the window look amateuristic.
Thanks for your thoughts,
Paul
Modified by Sprow (202) Wed, September 03 2014 - 20:20:53 GMT
- Attachment added: wimp543.png
I’m a bit confused when you say “the last icon in your example”, for me it’s the 2nd one (see attached screenshot) that’s not right with the label “Fill+Shade”.
Modified by Paul Reuvers (507) Thu, September 04 2014 - 15:27:06 GMT
- Attachment added: --- !ruby/object:File {}
Ah, now I’m the one who is confused :-) I now understand why I couldn’t get my point across.
Please check out the attached sprite. It is a screenshot of the same window.
As you will see, it is the bottom one that is affected here.
I have the problem here on 4 machines, which made me think…
It appears to be related to the configuration setting of ‘textured window backgrounds’.
It is the first thing I turn off when configuring a machine. When I turn it on, the problem disappears.
Modified by Paul Reuvers (507) Thu, September 04 2014 - 15:27:25 GMT
- Attachment added: screen,ff9
Ah, now I’m the one who is confused :-) I now understand why I couldn’t get my point across.
Please check out the attached sprite. It is a screenshot of the same window.
As you will see, it is the bottom one that is affected here.
I have the problem here on 4 machines, which made me think…
It appears to be related to the configuration setting of ‘textured window backgrounds’.
It is the first thing I turn off when configuring a machine. When I turn it on, the problem disappears.
Modified by Sprow (202) Thu, September 04 2014 - 22:32:24 GMT
That the textured backgrounds off does something different at least hints where to look, and I note that the colour that is chosen is correct for a faded 3D button (eg. a faded cancel button), as though the Wimp has forgotten what border type this icon is.
Should be possible to figure out what’s gone wrong…
Modified by Sprow (202) Fri, September 05 2014 - 07:38:39 GMT
- Status changed from Open to Fixed
Fixed in Wimp-5_45.
