Ticket #448 (Fixed)Mon Mar 19 08:32:31 UTC 2018
Ellipsis after Free in icon bar filers
| Reported by: | UserGuideEditor (2728) | Severity: | Minor |
| Part: | RISC OS: Application | Release: | |
| Milestone: | Status | Fixed |
Details by UserGuideEditor (2728):
Observation from User Guide review: the “Free” menu item in each of the filers should probably have an ellipsis (per the Style Guide) as it leads to a persistent dialogue.
Deferring this to a ticket since it would impact CDFSFiler, RAMFSFiler, [ADFS/SCSIFS/SDFS]Filer, and OmniClient and is rather late in the release cycle to make.
Changelog:
Modified by Chris Mahoney (1684) Sat, June 01 2019 - 04:43:58 GMT
“Free” is present in the following Messages files:
apache.RiscOS.Sources.FileSys.ADFS.ADFSFiler.Resources.UK.Messages
apache.RiscOS.Sources.FileSys.ADFS.ADFSFiler.Resources.UK.MessagesS
apache.RiscOS.Sources.FileSys.ADFS.ADFSFiler.Resources.UK.MessagesSD
apache.RiscOS.Sources.FileSys.CDFS.CDFSFiler.Resources.UK.Messages
apache.RiscOS.Sources.FileSys.NetFS.NetFiler.Resources.UK.Messages
apache.RiscOS.Sources.FileSys.PCCardFS.PCCFiler.Resources.UK.Messages
apache.RiscOS.Sources.FileSys.RAMFS.RAMFSFiler.Resources.UK.Messages
apache.RiscOS.Sources.Networking.AUN.Access.ShareFS.ShareFS.Resources.UK.Messages
apache.RiscOS.Sources.Networking.AUN.AUNMsgs.Resources.UK.Resources.ShareFS.Messages
apache.RiscOS.Sources.Networking.Omni.Apps.Omni.Resources.UK.Messages
I can’t find where SCSIFS or SDFS show their Free menu items (in fact I can’t find SDFSFiler at all!) so they still need to be tracked down. Are there any other filing systems that I’ve missed?
Modified by Chris Mahoney (1684) Sat, June 01 2019 - 04:46:34 GMT
Of course, not five minutes after posting I have a brainwave. SCSIFS and SDFS seem to use ADFS’ MessagesS and MessagesSD, respectively.
Modified by Chris Mahoney (1684) Sat, June 01 2019 - 08:39:23 GMT
I built a new Pi ROM with an ellipsis after all of those (except PCCardFS and Omni since they’re not in the Pi ROM). Tested SCSIFS, SDFS and RAMFS and all behaved as expected. I don’t have any of the other filing systems handy but presumably they’ll work correctly too.
Modified by Chris Mahoney (1684) Thu, March 19 2020 - 22:23:21 GMT
Changes have been made in:
ADFSFiler 1.15
RAMFSFiler 0.41
CDFSFiler 2.52
Omni 2.32
ShareFS 3.60
There is also a new version of PCCFiler, although its version is still 0.00.
NetFiler and AUNMsgs have not been updated as they’re not used under OS 5.
Modified by Sprow (202) Wed, March 25 2020 - 22:08:55 GMT
- Status changed from Open to Fixed
NetFiler is used in RISC OS 5 – it’s for Econet (whether real, or over TCP/IP using NetI).
Closing as the above list is done.
Modified by David Thomas (43) Sat, October 24 2020 - 16:47:10 GMT
This change is incorrect.
The point of the ellipsis is to indicate that the user is about to enter into a dialogue. It should be used only when activating the menu entry opens a dialogue box, which typically claims the input focus.
“Configure…” on the Task Manager’s main menu is another example where it’s wrong (it doesn’t open a dialogue box), yet “Configure…” on the Pinboard’s main menu is not (it opens a dialogue box).
Modified by Chris Mahoney (1684) Mon, October 26 2020 - 01:44:12 GMT
There was a similar change made to one of the other menus (I don’t recall which) shortly before this bug was logged. I noticed that Free also popped up a persistent window so I asked ROOL whether this should be changed too, which ultimately resulted in this bug being logged.
However, it looks like you’re right. Page 38 of the Style Guide says an ellipsis leads to a persistent dialogue box, and page 50 says that a PDB has at least one action button (Free has none) and no Close icon (Free has one). In my flimsy defence I didn’t have a searchable copy of the Style Guide when I first asked the question.
Modified by Chris Mahoney (1684) Mon, October 26 2020 - 01:48:28 GMT
It does, however, meet the page 38 criteria of remaining on screen until explicitly dismissed. Perhaps the Style Guide could be made a little clearer around when the ellipsis is expected.
For what it’s worth, if this were Windows then an ellipsis would not be used in this case, as the Free window is purely informational. Ellipses are used in Windows to indicate that an action will ask for further information before proceeding.
