Ticket #478 (Fixed)Sun Jan 26 20:51:40 UTC 2020
Reinstate scroll wheel scroll requests for windows without vertical scrollbars
| Reported by: | Matthew Phillips (473) | Severity: | Normal |
| Part: | RISC OS: Module | Release: | |
| Milestone: | Status | Fixed |
Details by Matthew Phillips (473):
We have a window with extra flags byte +39 bit 1 set to use extended scroll requests. Window flags word +28 bit 8 is set to receive scroll requests with auto-repeat.
If the window has a vertical scrollbar then rolling the scrollwheel on the mouse gives us Wimp poll code 10 (Scroll Request) and we can respond.
If the window has no vertical scrollbar then we do not get any scroll requests if we are on RISC OS 5.23 (18-Feb-18) but do get scroll requests on RISC OS 5.16. We think that we were receiving scroll requests with no scrollbar not very long ago (perhaps on 5.22?) and that this behaviour has been changed.
This is a bit of a nuisance, because applications may wish to respond to the scroll wheel even if there is no scroll bar. For example, over RiscOSM’s main window, rolling the scroll wheel allows you to zoom in or out and change the scale of the map.
Can this change be reverted so that applications can choose whether they want the events on the basis of the window flags and not based on whether there are scrollbars?
Changelog:
Modified by Sprow (202) Tue, January 28 2020 - 21:25:58 GMT
- Part changed from Unspecified to RISC OS: Module
According to
https://www.riscosopen.org/viewer/view/Products…
between RISC OS 5.16 and 5.22 we went from Wimp 5.07 to Wimp 5.47.
Nothing in the change log for that range
https://www.riscosopen.org/viewer/view/apache/R…
refers to scroll wheels, so either the fault isn’t in the Wimp (eg. USBDriver?) or it was an accident.
Modified by Sprow (202) Tue, January 28 2020 - 21:34:56 GMT
Maybe this?
https://gitlab.riscosopen.org/RiscOS/Sources/HW…
It mentions scroll wheels, and looking at window flags. What a pity the bounty to improve scroll wheel support attracted so little, as it’s truly weird that the USBDriver is tickling Wimp’s chin to make it work!
Modified by Jeffrey Lee (213) Mon, May 04 2020 - 12:57:52 GMT
- Status changed from Open to Fixed
With the addition of the WindowScroll module to the ROM, this should now be fixed.
- Windows (or icons) which request extended scroll requests will receive “extended” scroll requests, regardless of whether the window has scroll bars
- Otherwise, windows must have scrollbars in order to allow scrolling in the relevant direction (to avoid a recurrence of this issue – https://www.riscosopen.org/forum/forums/4/topic…). The window will receive either a regular “scroll” request, or a standard Open Window request (depending on whether the window supports normal scroll requests, and the user has enabled the “line scroll” / “line multiple” option in Configure)
