Ticket #580 (Fixed)Tue Jan 10 20:05:11 UTC 2023
Tool sprites from RISC OS 3.1 ResourceFS are rendered without masks
| Reported by: | Cameron Cawley (3514) | Severity: | Normal |
| Part: | RISC OS: Boot sequence | Release: | |
| Milestone: | Status | Fixed |
Details by Cameron Cawley (3514):
When using WindowManager 5.84 on RISC OS 3.1, attempting to load the tool sprites from the ROM by running “*ToolSprites Resources:$.Resources.Wimp.Tools” or by deleting the disc version results in the mask being ignored. Copying the file to disc doesn’t have this problem.
Ideally, the ROM versions should be used when the theme manager is disabled (as it is by default on RISC OS 3.1), but that’s a separate issue.
Changelog:
Modified by Sprow (202) Wed, April 26 2023 - 21:17:28 GMT
This appears to be a workaround for adding masks to the title bar so Eureka worked during Ursula development
https://gitlab.riscosopen.org/RiscOS/Sources/De…
and since Ursula (and later) all have ROM tools that look right without masks nobody’s noticed, whereas the ones in RISC OS 3.10 ROM rely on the underlying yellow fill to work. Presumably during Ursula development testing it on 3.10 wasn’t top priority. I think a better heuristic is to consider the presence of mask on sprites except for the titlebar (there’s already similar logic in dofunkytitlebar).
> Ideally, the ROM versions should be used when the theme manager is disabled (as it is by default
> on RISC OS 3.1), but that’s a separate issue.
No, the theme manager builds on top of the Universal !Boot, but to reduce memory use is disabled on RISC OS 3.10. Therefore you get only the features of Universal !Boot, and that is a minimum of a nested wimp and “NewLook” sprite set – LoadWimp goes to great lengths to add the missing sprites. It is not intended that the nested wimp default to the flat ROM icons.
Modified by Sprow (202) Sun, June 25 2023 - 08:39:53 GMT
- Status changed from Open to Fixed
Fixed in Wimp 5.86.
