Ticket #625 (Fixed)Tue Jan 09 23:15:40 UTC 2024
SparkFS fails to decode UUencoded files
| Reported by: | Cameron Cawley (3514) | Severity: | Normal |
| Part: | RISC OS: Software library | Release: | |
| Milestone: | Status | Fixed |
Details by Cameron Cawley (3514):
When attempting to use SparkFS to open these two files, it returns the error “Error uucoding”.
- https://web.archive.org/web/20001210010700/http…
- https://web.archive.org/web/19990225001039/http…
SparkFS 1.46 is able to open um_demo.arc, but seemingly not mc_demo.arc. The supplied instructions recommend using !Spark, so I’m assuming that both files worked with SparkFS at some point.
Changelog:
Modified by David Pitt (9872) Wed, January 10 2024 - 18:33:20 GMT
SparkFS can create uuencoded test files, shift-drag something to SparkFS’s icon bar icon and select UUcode. On decoding SparkFS 1.55 errors with “Error uucoding” and the output file is truncated. SparkFS 1.46 is fine. There has been a significant rewrite of the relevant code.
I suspect that mc_demo/arc, above, might be corrupt. SparkPlug complains of a bad header.
Modified by Sprow (202) Fri, January 19 2024 - 17:12:37 GMT
- Attachment added: test.zip
If you’re feeling brave, try the attached (replaces the RunImage).
The issue appears to be any file which after decoding isn’t an exact multiple of 3 long gives the error as the safety check on the line length isn’t accounting for the encoder adding up to 2 bytes of null padding.
Modified by David Pitt (9872) Fri, January 19 2024 - 18:43:16 GMT
This test RunImage does UUdecode all the examples here without error.
mc_demo/arc only UUdecodes to a data file, an Archive might have been expected, but I strongly suspect the original is corrupt.
Modified by Sprow (202) Thu, February 22 2024 - 11:16:43 GMT
- Status changed from Open to Fixed
Fixed in SparkFS 1.56, thanks for testing the RunImage (and I concur mc_demo.arc looks like the original is corrupt).
